Native CMake integration#118
Open
gabrielecastellano wants to merge 12 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a top-level CMake entrypoint to configure/build SimAI “natively” (without the existing wrapper scripts), primarily targeting the ns-3 simulator workflow and integrating Astra-sim sources into the ns-3 tree during configuration.
Changes:
- Introduces a new root
CMakeLists.txtto drive builds of the simulator (and optionally analytical/phy targets). - Adjusts
astra_ns3subproject CMake to only defaultCMAKE_BUILD_TYPEwhen unset. - Updates
.gitignoreto ignore additional build/config artifacts (including generic**/buildand**/cmake-cache).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| CMakeLists.txt | New root CMake configuration orchestrating Astra-sim + ns-3 build and creating a simulator symlink |
| astra-sim-alibabacloud/build/astra_ns3/CMakeLists.txt | Safer defaulting of CMAKE_BUILD_TYPE (doesn’t clobber user-provided value) |
| .gitignore | Adds ignores for config/build artifacts and introduces broad **/build / **/cmake-cache patterns |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
…o symlink/stubs generation for native ns3 headers
Co-authored-by: Copilot <[email protected]>
…AI into cmake-integration
Contributor
Author
|
I have merged latest changes from master and implemented comments from copilot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This creates a root CMakeLists that can be used to directly configure and build the project natively.
For instance:
This can be helpful for developing (code inspection features) and for future maintenance in general.
Works with PR aliyun/ns-3-alibabacloud#9 for the ns3 subproject.
(tested with simulator only)