Skip to content

chore: stop building packages during install #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lilienblum wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: stop building packages during install #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
510aed9
chore: stop building packages during install
lilienblum Jul 23, 2026
d9694de
ci: build packages for addon smoke test
lilienblum Jul 23, 2026
a77f64d
test: build packages before workspace tests
lilienblum Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,6 +520,11 @@ jobs:
- name: Install JavaScript dependencies
run: pnpm install --frozen-lockfile

- name: Build packages used by addon smoke test
run: |
pnpm --filter @alienplatform/core build
pnpm --filter @alienplatform/bindings build

- name: Download staged addon (${{ matrix.triple }})
uses: actions/download-artifact@v7
with:
Expand Down
1 change: 0 additions & 1 deletion packages/bindings/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
"scripts": {
"build": "tsdown && tsc -p tsconfig.build.json --emitDeclarationOnly",
"build:addon": "napi build --platform --release --cwd ../../crates/alien-bindings-node",
"prepare": "npm run build",
"test": "vitest run",
"test:bun": "bun scripts/run-bun-tests.mjs",
"test:ts": "tsc --noEmit",
Expand Down
1 change: 0 additions & 1 deletion packages/commands/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
},
"scripts": {
"build": "tsdown && tsc -p tsconfig.build.json --emitDeclarationOnly",
"prepare": "npm run build",
"test": "vitest run",
"test:integration": "vitest run --config vitest.integration.config.ts",
"test:bun": "BUN_EXPECTED=1 bun test tests/runtime-canary.test.ts tests/commands-client.test.ts tests/receiver.test.ts tests/presigned.test.ts",
Expand Down
1 change: 0 additions & 1 deletion packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
},
"scripts": {
"build": "tsdown",

@greptile-apps greptile-apps Bot Jul 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Root tests miss required builds

When a developer runs pnpm install followed by the root pnpm test command in a clean checkout, turbo test does not build workspace packages first, so imports of @alienplatform/core resolve to the absent dist/index.js and Vitest fails module resolution.

Knowledge Base Used:

Prompt To Fix With AI 
This is a comment left during a code review.
Path: packages/core/package.json
Line: 13

Comment:
**Root tests miss required builds**

When a developer runs `pnpm install` followed by the root `pnpm test` command in a clean checkout, `turbo test` does not build workspace packages first, so imports of `@alienplatform/core` resolve to the absent `dist/index.js` and Vitest fails module resolution.

**Knowledge Base Used:**
- [SDK and bindings: how apps reach storage, KV, queue, and vault](https://app.greptile.com/alien/-/custom-context/knowledge-base/alienplatform/alien/-/docs/sdk-bindings.md)
- [Remote Commands Protocol](https://app.greptile.com/alien/-/custom-context/knowledge-base/alienplatform/alien/-/docs/remote-commands.md)

How can I resolve this? If you propose a fix, please make it concise.

"prepare": "npm run build",
"test": "vitest run",
"test:ts": "tsc --noEmit",
"generate": "rm -rf src/generated && cargo run --quiet --bin schema_exporter --features=clap,openapi -p alien-core -- --output openapi.json && kubb generate",
Expand Down
1 change: 0 additions & 1 deletion packages/sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
},
"scripts": {
"build": "tsdown && tsc --emitDeclarationOnly",
"prepare": "npm run build",
"test": "vitest run --passWithNoTests",
"test:ts": "tsc --noEmit",
"generate": "./scripts/generate-proto.sh",
Expand Down
1 change: 1 addition & 0 deletions turbo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"cache": false
},
"test": {
"dependsOn": ["^build", "build"],
"cache": false
},
"test:ts": {
Expand Down
Loading