[docker] Add option to set qtAV version and fix Rocky issues by fabiencastan · Pull Request #3145 · alicevision/Meshroom

fabiencastan · 2026-06-21T13:53:16Z

No description provided.

gemini-code-assist

Code Review

This pull request introduces the ability to specify the QtAliceVision version (QTAV_VERSION) during the build process, updating the CMake configuration, Dockerfiles, and build scripts accordingly. The review feedback suggests several Dockerfile optimizations, such as combining multiple ENV instructions to reduce layers, combining package installation commands with dnf clean all to minimize image size, and removing commented-out code. Additionally, it recommends quoting variables to prevent shell expansion issues, providing a default value for QTAV_VERSION, and redirecting error messages to stderr in the build script.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

gemini-code-assist · 2026-06-21T13:55:03Z

 ARG CUDA_VERSION
 ARG ROCKY_VERSION
 FROM alicevision/meshroom-deps:${MESHROOM_VERSION}-av${AV_VERSION}-rocky${ROCKY_VERSION}-cuda${CUDA_VERSION}
+ARG QTAV_VERSION


Providing a default value for QTAV_VERSION (e.g., develop) ensures that direct builds of the Dockerfile (without using the helper script) do not fail or result in an empty version string during the CMake configuration.

ARG QTAV_VERSION=develop

gemini-code-assist · 2026-06-21T13:55:03Z

+ENV MESHROOM_DEV=/opt/Meshroom
+ENV MESHROOM_BUILD=/tmp/Meshroom_build
+ENV MESHROOM_BUNDLE=/opt/Meshroom_bundle
+ENV AV_INSTALL=/opt/AliceVision_install
+ENV QT_DIR=/opt/Qt/6.8.3/gcc_64
+ENV PATH="${PATH}:${MESHROOM_BUNDLE}"


Splitting the environment variables into multiple ENV instructions increases the number of layers in the Docker image. It is recommended to combine them into a single ENV instruction using backslashes to keep the image metadata clean and minimize layers.

ENV MESHROOM_DEV=/opt/Meshroom \ MESHROOM_BUILD=/tmp/Meshroom_build \ MESHROOM_BUNDLE=/opt/Meshroom_bundle \ AV_INSTALL=/opt/AliceVision_install \ QT_DIR=/opt/Qt/6.8.3/gcc_64 \ PATH="${PATH}:${MESHROOM_BUNDLE}"

gemini-code-assist · 2026-06-21T13:55:04Z


 # Build Meshroom plugins
-RUN cmake "${MESHROOM_DEV}" -DALICEVISION_ROOT="${AV_INSTALL}" -DCMAKE_INSTALL_PREFIX="${MESHROOM_BUNDLE}/qtPlugins"
+RUN cmake "${MESHROOM_DEV}" -DALICEVISION_ROOT="${AV_INSTALL}" -DQTALICEVISION_VERSION=${QTAV_VERSION} -DCMAKE_INSTALL_PREFIX="${MESHROOM_BUNDLE}/qtPlugins"


It is safer to wrap ${QTAV_VERSION} in double quotes to prevent potential shell expansion or word-splitting issues if the version string contains spaces or special characters.

RUN cmake "${MESHROOM_DEV}" -DALICEVISION_ROOT="${AV_INSTALL}" -DQTALICEVISION_VERSION="${QTAV_VERSION}" -DCMAKE_INSTALL_PREFIX="${MESHROOM_BUNDLE}/qtPlugins"

gemini-code-assist · 2026-06-21T13:55:04Z

+# cp ${MESHROOM_BUNDLE}/lib/PySide6/Qt/lib/libQt6Concurrent.so.6 ${MESHROOM_BUNDLE}/lib/PySide6/Qt/qml/QtQuick/Dialogs &&
+# cp ${MESHROOM_BUNDLE}/lib/PySide6/Qt/qml/Qt3D/Core/libQt63DCore.so.6 ${MESHROOM_BUNDLE}/lib/PySide6/Qt/qml/QtQuick/Dialogs && \
+# cp ${MESHROOM_BUNDLE}/lib/PySide6/Qt/qml/Qt3D/Input/libQt63DInput.so.6 ${MESHROOM_BUNDLE}/lib/PySide6/Qt/qml/QtQuick/Dialogs && \
+# cp ${MESHROOM_BUNDLE}/lib/PySide6/Qt/qml/Qt3D/Logic/libQt63DLogic.so.6 ${MESHROOM_BUNDLE}/lib/PySide6/Qt/qml/QtQuick/Dialogs && \
+# cp ${MESHROOM_BUNDLE}/lib/PySide6/Qt/qml/Qt3D/Render/libQt63DRender.so.6 ${MESHROOM_BUNDLE}/lib/PySide6/Qt/qml/QtQuick/Dialogs


Commented-out code should be removed to keep the Dockerfile clean and maintainable. If these library copies are no longer needed, please delete these lines entirely.

gemini-code-assist · 2026-06-21T13:55:04Z

+ENV MESHROOM_DEV=/opt/Meshroom
+ENV MESHROOM_BUILD=/tmp/Meshroom_build
+ENV QT_DIR=/opt/Qt/6.8.3/gcc_64
+ENV [email protected]
+ENV QT_CI_P=azerty1.


Combining these environment variables into a single ENV instruction reduces the number of layers in the Docker image.

ENV MESHROOM_DEV=/opt/Meshroom \ MESHROOM_BUILD=/tmp/Meshroom_build \ QT_DIR=/opt/Qt/6.8.3/gcc_64 \ [email protected] \ QT_CI_P=azerty1.

gemini-code-assist · 2026-06-21T13:55:04Z

+RUN dnf update -y --nobest
 RUN dnf install -y flex fontconfig freetype glib2-devel libICE
 RUN dnf install -y libX11 libXext libXi libXrender libSM
-RUN dnf install -y libXt-devel mesa-libGLU-devel mesa-libOSMesa-devel mesa-libGL-devel mesa-libEGL-devel
+RUN dnf install -y libXt-devel mesa-libGLU-devel mesa-libGL-devel mesa-libEGL-devel


Combining the package update and installation commands into a single RUN instruction reduces the layer count. Additionally, it is highly recommended to append && dnf clean all at the end of the package installation block to remove cached metadata and package files, which significantly reduces the final image size.

RUN dnf update -y --nobest && \ dnf install -y \ flex \ fontconfig \ freetype \ glib2-devel \ libICE \ libX11 \ libXext \ libXi \ libXrender \ libSM \ libXt-devel \ mesa-libGLU-devel \ mesa-libGL-devel \ mesa-libEGL-devel

gemini-code-assist · 2026-06-21T13:55:04Z

+set -ex

 test -z "$MESHROOM_VERSION" && MESHROOM_VERSION="$(git rev-parse --abbrev-ref HEAD)-$(git rev-parse --short HEAD)"
+test -z "$QTAV_VERSION" && echo "qtAliceVision version not specified, set QTAV_VERSION in the environment" && exit 1


Error messages should be redirected to standard error (stderr) instead of standard output (stdout) to follow standard CLI practices.

Suggested change

test -z "$QTAV_VERSION" && echo "qtAliceVision version not specified, set QTAV_VERSION in the environment" && exit 1

test -z "$QTAV_VERSION" && echo "qtAliceVision version not specified, set QTAV_VERSION in the environment" >&2 && exit 1

codecov · 2026-06-21T13:55:47Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.34%. Comparing base (69493f5) to head (526f3b6).
⚠️ Report is 19 commits behind head on develop.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3145      +/-   ##
===========================================
- Coverage    85.35%   85.34%   -0.01%     
===========================================
  Files           73       73              
  Lines        11453    11460       +7     
===========================================
+ Hits          9776     9781       +5     
- Misses        1677     1679       +2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

fabiencastan added 3 commits June 21, 2026 15:48

[docker] add option to set qtAV version

1e2218f

[docker] fixes for Rocky

4fc8281

[docker] remove extra libs copy

dd565dc

fabiencastan added this to the Meshroom 2026.1.0 milestone Jun 21, 2026

fabiencastan requested a review from cbentejac June 21, 2026 13:53

fabiencastan added scope:deploy Anything related to deploying (packaging etc) docker labels Jun 21, 2026

gemini-code-assist Bot reviewed Jun 21, 2026

View reviewed changes

fabiencastan added 3 commits June 25, 2026 10:36

[docker] linux: fix default lib folder

02ad8ea

[docker] / is not allowed in docker names

257b2ed

[docker] linux: fix dnf issue and move to aqt

526f3b6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[docker] Add option to set qtAV version and fix Rocky issues#3145

[docker] Add option to set qtAV version and fix Rocky issues#3145
fabiencastan wants to merge 6 commits into
developfrom
fix/dockerRocky

fabiencastan commented Jun 21, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Jun 21, 2026

Uh oh!

gemini-code-assist Bot Jun 21, 2026

Uh oh!

gemini-code-assist Bot Jun 21, 2026

Uh oh!

gemini-code-assist Bot Jun 21, 2026

Uh oh!

gemini-code-assist Bot Jun 21, 2026

Uh oh!

gemini-code-assist Bot Jun 21, 2026

Uh oh!

gemini-code-assist Bot Jun 21, 2026

Uh oh!

codecov Bot commented Jun 21, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	test -z "$QTAV_VERSION" && echo "qtAliceVision version not specified, set QTAV_VERSION in the environment" && exit 1
	test -z "$QTAV_VERSION" && echo "qtAliceVision version not specified, set QTAV_VERSION in the environment" >&2 && exit 1

Uh oh!

Uh oh!

Conversation

fabiencastan commented Jun 21, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

codecov Bot commented Jun 21, 2026 •

edited

Loading