feat(config): add state.toml + keychain store and migrate config.toml (1/2)#229
Draft
LorrisSaintGenez wants to merge 1 commit into
Draft
feat(config): add state.toml + keychain store and migrate config.toml (1/2)#229LorrisSaintGenez wants to merge 1 commit into
LorrisSaintGenez wants to merge 1 commit into
Conversation
Co-authored-by: Cursor <[email protected]>
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Security | 1 critical |
🟢 Metrics 6 duplication
Metric Results Duplication 6
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
state.toml(non-secrets) + OS keychain (secrets) as the new credential source of truth, migrated once fromconfig.tomlat startup.config.tomlfallback; commands still writeconfig.toml(the write flip lands in the stacked follow-up PR).--profileflag (still resolved via stored aliases until v2.0).Test
config.toml, runalgolia indices listonce: it migrates tostate.toml(application id +alias, no secret) and the OS keychain (API key), then succeeds —config.tomlis left intact.config.tomland re-runalgolia indices list: still works, confirming reads now resolve fromstate.toml+ keychain (and no re-migration happens).algolia --profile <alias> indices list: resolves via the stored alias and prints the--profiledeprecation notice.Made with Cursor
GROUT-305