Skip to content

馃Ч Consolidate duplicate test files and refactor integration tests - #14

Draft
alexj11324 wants to merge 1 commit into
mainfrom
consolidate-duplicate-test-models-2548891126000728027
Draft

馃Ч Consolidate duplicate test files and refactor integration tests#14
alexj11324 wants to merge 1 commit into
mainfrom
consolidate-duplicate-test-models-2548891126000728027

Conversation

@alexj11324

Copy link
Copy Markdown
Owner

This PR addresses a code health issue where duplicate test files existed for model testing. It consolidates test_models_fixed.ts into test_models.ts and refactors the integration test suite to reduce code duplication by importing shared protobuf and discovery utilities from the compiled out/ directory (since the original src/ is absent). It also updates the test:models script in package.json to ensure consistency.


PR created automatically by Jules for task 2548891126000728027 started by @alexj11324

- Removed duplicate `test/integration/test_models_fixed.ts` by consolidating it into `test/integration/test_models.ts`.
- Refactored integration tests (`test_models.ts`, `test_antigravity_api.ts`, `test_oauth_401_diagnosis.ts`) to use shared utilities from `out/antigravityClient/protobuf` and `out/antigravityClient/discovery`.
- Fixed incorrect import in `test_oauth_extraction.ts`.
- Updated `package.json` test scripts to reflect the consolidated file.
- Addressed code review feedback regarding the missing `src/` directory.
@google-labs-jules

Copy link
Copy Markdown

馃憢 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 馃憖 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant