Feature/add connect - #4
Open
alexanderkasten wants to merge 2 commits into
Open
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements to the Server-Sent Events (SSE) handling in the
useSSEhook and theCounterWithDisconnectcomponent. The main changes include adding aconnectmethod to manage SSE connections more effectively and refactoring the cleanup logic.Enhancements to SSE handling:
src/client/use-sse.ts: Added aconnectmethod to theSSEResultinterface to allow explicit connection management.src/client/use-sse.ts: Introduced acleanupRefto store the cleanup function and updated theclosemethod to use this reference. This ensures proper cleanup of resources.src/client/use-sse.ts: Refactored theuseEffectto call theconnectmethod directly and store the destructor incleanupRef. This simplifies the connection management logic.Updates to
CounterWithDisconnectcomponent:example/src/app/components/CounterWithDisconnect.tsx: Updated thehandleConnectfunction to call theconnectmethod forcounter,milestone, andcloseMessageto establish SSE connections.