feat: enable migrate to be dry run#4
Closed
ale8k wants to merge 2 commits into
Closed
Conversation
Enables migrate being dry run. This runs the migrate command up until the final InitiateMigration call, ensuring pre-checks pass.
luci1900
approved these changes
Dec 10, 2025
luci1900
left a comment
luci1900
left a comment
There was a problem hiding this comment.
Looks fine.
Possibly more testing that necessary.
ale8k
pushed a commit
that referenced
this pull request
Jul 10, 2026
Addresses code review findings: 1. Issue #1 - Enforce Azure's /64 IPv6 subnet requirement: - validateIPFamilyForCreate now parses CIDR prefixes to verify both the address family (IPv6) AND the exact prefix length (/64). - Azure requires IPv6 subnets to be exactly /64 in size; the prior check only verified address type, allowing non-/64 IPv6 prefixes through (e.g. fd00::/56), which would later fail at Azure's API with a cryptic error. Now fails fast during precheck/creation. - Added net import to support CIDR parsing. - Added regression test TestStartInstanceIPFamilyDualPlacementNon64IPv6Subnet to guard against accepting invalid IPv6 prefix lengths. 2. Issue #4 - Remove unreachable SKU warning: - Deleted warning branch at line 974-977 that checked if SKU != Standard during dual-stack IPv6 PIP creation. This branch was unreachable because validateIPFamilyForCreate rejects Basic SKU earlier, leaving Standard as the only possible value at this point. All tests pass including the new regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables juju migrate to be dry run. This runs the migrate command up until the final InitiateMigration call, ensuring pre-checks pass.
Checklist
QA steps
I haven't QA'd a precheck failure but I think it'll be ok as it is covered by the tests.
Links
Launchpad bug: https://bugs.launchpad.net/juju/+bug/
Jira card: JUJU-