Feat/landing page logo#68
Merged
Merged
Conversation
The gold/silver/bronze rank pills were keyed to the displayed row index, so re-sorting the event results table (e.g. Time descending or by Driver/Class/Car #) put the trophy on the wrong driver — the slowest entry got the gold "1" when sorted in reverse. Derive rank once from the time-based ranking (reusing the existing deltaByRow memo, keyed by the stable LeaderboardRow object) and read it from both the desktop pill cell and the mobile card, so rank is correct under any display sort. Rows with no time render no pill instead of "0". Co-Authored-By: Claude Opus 4.8 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a logo to the pre-auth landing page.