Conversation
Add a calendar-based editor for the promotion windows carried on ProjectConfig.spec.promotionWindows and ClusterConfig.spec.promotionWindows. Windows are stored unparsed, as iCal DTSTART/DTEND plus an RFC 5545 RRULE. The UI expands them client-side with rrule and renders each occurrence on a FullCalendar week/month grid, where a drag drafts a new window and a click edits an existing one. The modal covers effect (Allow/Deny), time zone, recurrence, enablement, description and the Stage/Project selectors; a set of recipes seeds the common shapes (business hours, weekend freeze, release train, carve-out). The pages hang off the existing settings menus as nested views under Cluster Config and ProjectConfig, declared inline as children of those entries. antd's DatePicker and TimePicker are bound to dayjs by default, which would have meant a second date library alongside date-fns. Generate them over date-fns instead, so every date in this feature is a plain Date. Adds @fullcalendar/react, rrule, and rc-picker -- the last only to reach the date-fns generate config, and pinned to the version antd already resolves. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Add an optional featureFlags object alongside extensions on the extensions context. The promotion windows subpages read it and are only declared when promotionWindows is on, so they get neither a menu entry nor a route. Nothing sets the flag in open source, so the pages stay hidden unless a distribution passes featureFlags through the extensions provider. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
kargo-governance-bot
Bot
added
the
needs/area
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kargo-governance-bot
Bot
added
needs/kind
Marvin9
added
kind/enhancement
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
rpelczar
reviewed
Sep 15, 2026
Contributor
There was a problem hiding this comment.
I don't think it's a good idea to call it featureFlags in that case.
Can we just check if there is any extension and then show this view?
Contributor
There was a problem hiding this comment.
Can we call it promotion-window-form-utils?
Contributor
There was a problem hiding this comment.
I think the modal is too wide. Can we make this a bit narrower?
Comment on lines
+96
to
+99
| <Button | ||
| icon={<FontAwesomeIcon icon={faTrash} size='sm' />} | ||
| onClick={() => labels.remove(index)} | ||
| /> |
rpelczar
reviewed
Sep 15, 2026
Comment on lines
+175
to
+190
| <Flex gap={8} justify='end'> | ||
| <Button | ||
| icon={<FontAwesomeIcon icon={faPencil} size='sm' />} | ||
| onClick={() => onEdit(promotionWindow)} | ||
| size='small' | ||
| color='default' | ||
| variant='filled' | ||
| /> | ||
| <Button | ||
| icon={<FontAwesomeIcon icon={faTrash} size='sm' />} | ||
| onClick={() => onDelete(promotionWindow)} | ||
| size='small' | ||
| color='danger' | ||
| variant='filled' | ||
| /> | ||
| </Flex> |
Contributor
There was a problem hiding this comment.
Please make this consistent and add labels
| className='min-h-full' | ||
| extra={ | ||
| <Button | ||
| type='primary' |
Contributor
There was a problem hiding this comment.
use default to make this consistent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.