Skip to content

fix(api): stream a notice instead of erroring when verification logs requested before Job starts - #7204

Open
alombardo4 wants to merge 1 commit into
akuity:mainfrom
alombardo4:fix/analysisrun-logs-pending-job
Open

alombardo4 wants to merge 1 commit into
akuity:mainfrom
alombardo4:fix/analysisrun-logs-pending-job

Conversation

@alombardo4

Copy link
Copy Markdown

Description

Closes #7203

Until Argo Rollouts records the first measurement for a job metric, an AnalysisRun's status has no Job namespace/name, and requesting logs during that window returns an error the UI surfaced as an alert. When the run is not yet complete and the Job cannot be resolved, respond with an SSE event saying logs are not available yet. Completed runs with missing Job metadata still error as before.

Screenshot 2026-09-14 at 3 57 20 PM

Checklist

Eligibility

  • Linked to an existing issue with no blocking labels (kind/proposal, needs discussion, needs research, maintainer only, area/security, size/large, size/x-large, size/xx-large).
  • Changes documentation only.
  • Changes ten lines or fewer.

Quality

  • Adds or updates corresponding tests.
  • Adds or updates corresponding documentation.

AI Use Disclosure

This PR was written:

  • By a human without AI assistance.
  • By a human with AI assistance. A human has reviewed every line prior to opening the PR.
  • By an AI with human supervision. A human has reviewed every line prior to opening the PR.
  • Entirely by an AI. No human has reviewed this prior to opening the PR.

Sign-Off

All commits:

  • Are signed off by their author (git commit -s) (required)
  • Are cryptographically signed (git commit -S) (encouraged)

…are requested before the Job starts

Until Argo Rollouts records the first measurement for a job metric, an
AnalysisRun's status carries no Job namespace/name, and requesting logs
during that window returned an error the UI surfaced as an alert. When
the run is not yet complete and the Job cannot be resolved, respond with
an SSE event saying logs are not available yet. Completed runs with
missing Job metadata still error as before.

Fixes akuity#7203

Signed-off-by: Alec Lombardo <[email protected]>
@netlify

netlify Bot commented Sep 14, 2026

Copy link
Copy Markdown

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit dd1c7f1
🔍 Latest deploy log https://app.netlify.com/projects/docs-kargo-io/deploys/6aa8520b2dea6b0008166f3f
😎 Deploy Preview https://deploy-preview-7204.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kargo-governance-bot kargo-governance-bot Bot added needs/area Issue or PR needs to be labeled to indicate what parts of the code base are affected needs/kind Issue or PR needs to be labeled to clarify its nature needs/priority Priority has not yet been determined; a good signal that maintainers aren't fully committed labels Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs/area Issue or PR needs to be labeled to indicate what parts of the code base are affected needs/kind Issue or PR needs to be labeled to clarify its nature needs/priority Priority has not yet been determined; a good signal that maintainers aren't fully committed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verification log requests error out until the AnalysisRun's Job has started

1 participant