fix(api): stream a notice instead of erroring when verification logs requested before Job starts - #7204
Open
alombardo4 wants to merge 1 commit into
Open
fix(api): stream a notice instead of erroring when verification logs requested before Job starts#7204alombardo4 wants to merge 1 commit into
alombardo4 wants to merge 1 commit into
Conversation
…are requested before the Job starts Until Argo Rollouts records the first measurement for a job metric, an AnalysisRun's status carries no Job namespace/name, and requesting logs during that window returned an error the UI surfaced as an alert. When the run is not yet complete and the Job cannot be resolved, respond with an SSE event saying logs are not available yet. Completed runs with missing Job metadata still error as before. Fixes akuity#7203 Signed-off-by: Alec Lombardo <[email protected]>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #7203
Until Argo Rollouts records the first measurement for a job metric, an AnalysisRun's status has no Job namespace/name, and requesting logs during that window returns an error the UI surfaced as an alert. When the run is not yet complete and the Job cannot be resolved, respond with an SSE event saying logs are not available yet. Completed runs with missing Job metadata still error as before.
Checklist
Eligibility
kind/proposal,needs discussion,needs research,maintainer only,area/security,size/large,size/x-large,size/xx-large).Quality
AI Use Disclosure
This PR was written:
Sign-Off
All commits:
git commit -s) (required)git commit -S) (encouraged)