fix(ui): validate OIDC authorization nonce - #7186
Draft
chris-dare-dev wants to merge 1 commit into
Draft
chris-dare-dev wants to merge 1 commit into
chris-dare-dev wants to merge 1 commit into
Conversation
Signed-off-by: Chris Dare <[email protected]>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Automated Policy NoticeThis pull request has been converted to a draft because the linked issue (#6797) has not been unblocked for external contribution. Maintainers do not routinely review drafts. The issue currently has the following blocking label(s): To move forward:
See the Contributor Guide for full details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #6797
Cognito can add a nonce claim to the ID token during a federated login. Kargo did not send or retain a nonce and therefore asked oauth4webapi to expect no nonce, causing the first federated login to fail claim validation.
This change:
The PR is opened as a draft because #6797 currently has the blocking area/security label.
Checklist
Eligibility
kind/proposal,needs discussion,needs research,maintainer only,area/security,size/large,size/x-large,size/xx-large).Quality
AI Use Disclosure
This PR was written:
Sign-Off
All commits:
git commit -s) (required)git commit -S) (encouraged)Verification
pnpm exec vitest run src/features/auth/oidc-utils.test.tspnpm exec eslint src/features/auth/oidc-login.tsx src/features/auth/oidc-utils.ts src/features/auth/oidc-utils.test.ts --max-warnings=0pnpm run typecheckpnpm run build