Conversation
google.golang.org/api is frozen because its own go.mod pins google.golang.org/grpc and google.golang.org/protobuf. Raising it drags both past the versions frozen on the release branches, so ignoring those two by name was never holding on its own. connectrpc.com/connect widens to connectrpc.com/*, which picks up connectrpc.com/grpchealth. github.com/bufbuild/buf is frozen for the same reason as protobuf: it drives protobuf code generation. golangci-lint is frozen on the branches that still have a hack/tools module, which hack/tools.mk greps for the version of the prebuilt linter binary to install -- raising it there changes what CI enforces on code that is already frozen. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Signed-off-by: Kent Rancourt <[email protected]>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7185 +/- ##
==========================================
+ Coverage 35.24% 35.29% +0.04%
==========================================
Files 858 859 +1
Lines 70677 70737 +60
==========================================
+ Hits 24910 24964 +54
- Misses 45767 45773 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four freezes, batched into one change because every edit to this file draws a fresh flurry of update PRs.
google.golang.org/api, on all four release branches. This is the one that matters. Everygo-minorgroup PR on every release branch — #7162, #7167, #7169, #7170 — movedgoogle.golang.org/grpcfrom 1.82.1 to 1.83.2 andgoogle.golang.org/protobuffrom 1.36.11 to 1.36.12, and neither was among the listed updates. They came along for the ride:google.golang.org/[email protected]requires exactly those two versions in its owngo.mod, so minimum version selection raises the root module. Ignoring grpc and protobuf stops Dependabot proposing them and does nothing about the module graph dragging them, which is why those PRs were unmergeable however many ignore lines we added. None of the other subjects in those PRs requires anything newer, so this is the only dependency that needed to move. The cost is that GCP client library patches no longer reach the release branches.connectrpc.com/*, widened fromconnectrpc.com/connect.connectrpc.com/grpchealthwas a subject in every one of those group PRs and the exact name did not cover it.github.com/bufbuild/buf, on all four branches, for the same reason gRPC and protobuf are frozen:bufdrives protobuf code generation, and moving it on a branch whose protobuf story is deliberately pinned invites a regeneration we don't want. It lives in/hack/toolson release-1.8 through release-1.10 and in the root module — as atooldirective — on release-1.11.github.com/golangci/golangci-lint, on release-1.8, release-1.9 and release-1.10 — the branches that still have ahack/toolsmodule. Nothing is built from that module:hack/tools.mkgrepshack/tools/go.modfor the version of the prebuilt linter binary to install. Raising the linter on a stable branch therefore changes what CI enforces, and can only turn up new findings in code that is already frozen. release-1.11 andmainpin the version directly inhack/tools.mk, so Dependabot never sees it there.As with the freezes already in this file, each ignore line goes on every
gomodentry for the branches it applies to, rather than only the entry whose module currently has the dependency.Follow-ups, not in this PR
/hack/toolsgomodentries could be dropped outright. Everything in that module is a version pin for a dev or CI tool, none of it ships to users, and most of what remains unfrozen there —go-swagger,swag,golang.org/x/tools— regenerates checked-in code.github.com/go-openapi/validatefrom 0.26.5 to 1.0.0 inside thego-patchgroup. A 0.x to 1.0 jump reached a branch that ignoresversion-update:semver-major, because Dependabot classified it as a patch. That applies to every 0.x dependency on these branches.🤖 Generated with Claude Code