fix(validation): prevent siret to be False#4
Open
lermit wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello
In the
get_directory_lines_parsedfunction we can have a bug if the customer company is a private one.In this case the
siretvariable is False.Workflow :
1/ Odoo call the get_directory_lines_parsed function with the partner siren in
siren_or_siretvariables2/ line 597 the
siretvariable is set toFalse3/ line 625 the
dir_siretis set to siret returned by directory4/ line 746 expected_identifier is construct with
siren_siretwhere siret isFalse5/ line 750 expected_identifier is compared to identifier returned by Directory (SuperPDP in my test). Test fail
I'm not sure my solution is the correct one but this one allow e-invoicing private company.
Thank you very very very much for your work on the e-invoicing intégration for Odoo. Your work is awesome !
Regards