Skip to content

thread: add trusted hosts for remote requests #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
laarmen wants to merge 1 commit into
base: master
Choose a base branch
from
Open

thread: add trusted hosts for remote requests #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions dodo/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,13 @@
from embedded image tags or iframes. If set to True, Dodo will not allow these requests.
"""

html_block_remote_requests_trusted_hosts = []
"""A list of trusted hosts for HTML remote requests.

Dodo will let any request to those hosts through, even if
:func:`~dodo.settings.html_block_remote_requests` is True.
"""

html_confirm_open_links = True
"""Display a confirmation dialog before opening a link in browser

Expand Down
9 changes: 7 additions & 2 deletions dodo/thread.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,8 +202,13 @@ def requestStarted(self, request: QWebEngineUrlRequestJob) -> None:

class RemoteBlockingUrlRequestInterceptor(QWebEngineUrlRequestInterceptor):
def interceptRequest(self, info):
if info.requestUrl().scheme() not in app.LOCAL_PROTOCOLS:
info.block(settings.html_block_remote_requests)
url = info.requestUrl()
if url.scheme() not in app.LOCAL_PROTOCOLS:
trusted_hosts = settings.html_block_remote_requests_trusted_hosts
info.block(
settings.html_block_remote_requests
and url.host() not in trusted_hosts
)

RE_REGEX = re.compile(r'^R[Ee]: ')
class ThreadItem:
Expand Down