Optional dark background for HTML view#140
Open
laarmen wants to merge 2 commits into
Open
Conversation
We still need the background toggling because even in dark mode it'll use a white background when there is no content.
In akissinger#135 we forced the background color to the theme one for the email body view to avoid a white flash when first entering a thread view before it switches to plain text view. However, it kinda broke the HTML view as most emails out there assume a default white background, making them unreadable if you're using a dark theme.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We broke HTML view a little bit when I merge #135 as it takes on the new background color but keeps a dark text.
This fixes it in two manners: