Font scaling for tab bar and column headers#132
Open
klement wants to merge 3 commits into
Open
Conversation
…aders Tab titles and search column headers (date, from, subject, tags) were using the system default font, which looks inconsistent when users configure large custom fonts for the rest of the UI. Add separate tab_font/tab_font_size and header_font/header_font_size settings so these elements can be styled independently. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Subclass QTabBar with tabSizeHint() override so Qt's layout system properly accommodates custom tab font sizes. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Same approach as TabBar: subclass QHeaderView and override sizeHint() to add padding based on font metrics. Co-Authored-By: Claude Opus 4.6 <[email protected]>
laarmen
requested changes
Jun 22, 2026
laarmen
left a comment
laarmen
left a comment
Collaborator
There was a problem hiding this comment.
There's a white strip that appears on unselected tabs after doing a local merge (without touching any configuration), this should be fixed before we can merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
tab_font/tab_font_sizeandheader_font/header_font_sizesettings so users can control the font used in the tab bar and the search-result column headers.Without these settings, the tab bar height and column header height are fixed by Qt's default metrics, which can clip text when users configure a large system font or a large
search_font_size. This change:dodo.settings.tab_font/dodo.settings.tab_font_sizeanddodo.settings.header_font/dodo.settings.header_font_size(default empty/0 → use system font)QTabBarwith a customsizeHintso the tab height adjusts to the configured fontQHeaderViewwith a customsizeHintso the header height adjusts similarlyUsage in
config.py:Test plan
dodo.settings.tab_font_sizeand verify the tab bar grows to fit without clippingdodo.settings.header_font_sizeand verify column headers grow to fit