Skip to content

thread: fix get_last_msg_idx() crash when called with root index #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
klement wants to merge 1 commit into
base: master
Choose a base branch
from
Open

thread: fix get_last_msg_idx() crash when called with root index #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions dodo/thread.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,10 @@ def _fetch_matching_ids(self) -> set[str]:
return set(json.loads(r.stdout))

def get_last_msg_idx(self, parent: QModelIndex=QModelIndex()) -> QModelIndex:
if not parent.isValid():
if not self.roots:
return QModelIndex()
return self.get_last_msg_idx(self.createIndex(len(self.roots)-1, 0, self.roots[-1]))
children = parent.internalPointer().children
if children:
return self.get_last_msg_idx(self.index(len(children)-1, 0, parent))
Expand Down