Fix finding GPG encryption keys#123
Open
The-Compiler wants to merge 1 commit into
Open
Conversation
laarmen
approved these changes
Mar 13, 2026
laarmen
left a comment
laarmen
left a comment
Collaborator
There was a problem hiding this comment.
I don't really understand what that fixes either, but it looks sane to me and a bit more readable.
LGTM, only a small suggestion.
| for uid in key['uids'] for addr in recipients)] | ||
| all_keys = Gpg.list_keys() | ||
| recipients_keys = set() | ||
| for _, addr in email.utils.getaddresses([msg[key] for key in ['From', 'To', 'Cc']]): |
Collaborator
There was a problem hiding this comment.
suggestion:
Suggested change
| for _, addr in email.utils.getaddresses([msg[key] for key in ['From', 'To', 'Cc']]): | |
| for _, addr in util.get_header_addresses(msg, ['From', 'To', 'Cc']): |
The micro-optimizer in me even wants to change that helper method type signature to take in any iterable so that you can pass in a tuple rather than a list 😁 .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be honest I don't remember anymore why I wrote this commit. I think I had an issue where a parse error in
email.utils.getaddressescaused weird behavior or something? In any case, I think it's a nice clean up and I have been running with it locally for a while now.