Skip to content

Add dependabot smoke test reminder comment#3

Draft
ajalon1 wants to merge 1 commit into
mainfrom
claudy/wizardly-noether-4a8db6
Draft

Add dependabot smoke test reminder comment#3
ajalon1 wants to merge 1 commit into
mainfrom
claudy/wizardly-noether-4a8db6

Conversation

@ajalon1

@ajalon1 ajalon1 commented May 11, 2026

Copy link
Copy Markdown
Owner

RATIONALE

Dependabot PRs consistently fail their first smoke test run. After investigation, the root cause is GitHub's secret isolation model: any workflow triggered on a dependabot-created PR runs with Secret source: Dependabot, which means only Dependabot-specific secrets are available. Repository secrets like DR_API_TOKEN are not injected. The smoke tests build fine but fail immediately at authentication.

A human maintainer adding the run-smoke-tests label upgrades the context to Secret source: Actions (full secrets), which is why the manual-label path works.

CHANGES

Adds a dependabot-reminder job to checks.yaml that fires on any PR where github.actor == 'dependabot[bot]' and posts a comment explaining:

  • Why smoke tests can't run automatically on these PRs
  • That a maintainer must add the run-smoke-tests label before merging

The comment appears immediately when the PR opens, so reviewers see it before they start reviewing rather than discovering the constraint at merge time.

NOTES

  • The job has no needs: dependency so it posts as early as possible
  • Uses GITHUB_TOKEN (comment appears from github-actions[bot])
  • Does not affect non-dependabot PRs
  • The proper long-term fix would be adding DR_API_TOKEN as a Dependabot secret in repo settings, which would allow fully automated smoke tests on these PRs

@github-actions github-actions Bot added the go label May 11, 2026
Dependabot PRs run with Secret source: Dependabot, which restricts
access to repository secrets (including DR_API_TOKEN). This causes
smoke tests to silently fail when auto-triggered by the go label.

A maintainer must manually add the run-smoke-tests label to get a
passing run. This job posts a comment on every dependabot PR so that
fact is visible at review time rather than discovered at merge time.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
@ajalon1 ajalon1 force-pushed the claudy/wizardly-noether-4a8db6 branch from c4f2463 to 5c9daba Compare May 11, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant