Cleanup formatting and update dependencies - #140
Open
electrum wants to merge 15 commits into
Open
Conversation
|
Caution Review failedAn error occurred during the review process. Please try again later. 📝 WalkthroughWalkthroughThe pull request updates CI, release, and Maven Java configuration to Java 25. It reformats Java declarations, constructors, callbacks, annotations, generated fixtures, and test helpers. Unused lambda parameters are replaced with 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
electrum
changed the title
Regenerate testing thrift classes without modifications:
thrift --gen java:generated_annotations=suppress \
-out drift-integration-tests/src/test/java \
drift-integration-tests/src/test/resources/scribe.thrift
thrift --gen java:generated_annotations=suppress \
-out drift-transport-apache/src/test/java \
drift-transport-apache/src/test/resources/scribe.thrift
thrift --gen java:generated_annotations=suppress \
-out drift-transport-netty/src/test/java \
drift-transport-netty/src/test/resources/scribe.thrift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.