Skip to content

ci: use positive include patterns in paths-filter for required check compatibility#325

Draft
Aaron ("AJ") Steers (aaronsteers) wants to merge 2 commits intomainfrom
devin/1771233263-paths-filter-includes
Draft

ci: use positive include patterns in paths-filter for required check compatibility#325
Aaron ("AJ") Steers (aaronsteers) wants to merge 2 commits intomainfrom
devin/1771233263-paths-filter-includes

Conversation

@aaronsteers
Copy link
Copy Markdown
Member

Summary

Fixes the dorny/paths-filter configuration in the check-paths job so that docs-only PRs correctly skip the "Validate Generation (Dry Run)" required check.

The previous configuration used a catch-all '**' with negated exclusions ('!docs/**', etc.). Due to dorny/paths-filter's OR semantics, every changed file matched at least one negation pattern, causing generation=true on every PR — including docs-only ones. Execution log showing the bug.

This PR replaces the exclusion patterns with explicit positive includes for paths that actually affect generation: scripts/**, gen.yaml, gen.lock, .speakeasy/**, .github/**, internal/**, go.mod, go.sum, main.go, provider/**.

Review & Testing Checklist for Human

  • Is the include list complete? If any path that affects Speakeasy generation is missing, the validate job will be incorrectly skipped for PRs touching that path. Cross-check against what generate-command.yml actually reads/writes.
  • Test on a docs-only PR (like #321) — the check-paths job should output should_run=false and the validate job should be skipped (reported as "skipped", not "pending").
  • Test on a real code PR — confirm the validate job still runs when non-docs files change.

Notes

@devin-ai-integration
Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions
Copy link
Copy Markdown
Contributor

Thanks for opening this pull request!

Your contribution is appreciated. Here are some helpful tips and resources.

💡 Show Tips and Tricks

Terraform Example Commands

  • /tf-examples project=pre-1.0 action=plan - Run terraform plan on the pre-1.0 example project
  • /tf-examples project=1.0 action=plan - Run terraform plan on the 1.0 example project
  • /tf-examples project=all action=plan - Run terraform plan on all example projects
  • /tf-examples project=pre-1.0 action=apply - Apply terraform changes to the pre-1.0 example project
  • /tf-examples project=pre-1.0 action=destroy - Destroy terraform resources in the pre-1.0 example project
📚 Show Repo Guidance

About This Repository

This repository uses Speakeasy to generate the Terraform provider from the Airbyte OpenAPI specification. The CI will automatically build the provider, validate code generation, and run acceptance tests across Terraform versions 1.0-1.4.

Note: This is a generated codebase. Direct modifications to generated files are not accepted - changes must be made to the upstream OpenAPI spec.

📝 Edit this welcome message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant