ci: use positive include patterns in paths-filter for required check compatibility#325
Draft
Aaron ("AJ") Steers (aaronsteers) wants to merge 2 commits intomainfrom
Draft
Conversation
Co-Authored-By: AJ Steers <[email protected]>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
Thanks for opening this pull request!Your contribution is appreciated. Here are some helpful tips and resources. 💡 Show Tips and TricksTerraform Example Commands
📚 Show Repo GuidanceAbout This RepositoryThis repository uses Speakeasy to generate the Terraform provider from the Airbyte OpenAPI specification. The CI will automatically build the provider, validate code generation, and run acceptance tests across Terraform versions 1.0-1.4. Note: This is a generated codebase. Direct modifications to generated files are not accepted - changes must be made to the upstream OpenAPI spec. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
dorny/paths-filterconfiguration in thecheck-pathsjob so that docs-only PRs correctly skip the "Validate Generation (Dry Run)" required check.The previous configuration used a catch-all
'**'with negated exclusions ('!docs/**', etc.). Due todorny/paths-filter's OR semantics, every changed file matched at least one negation pattern, causinggeneration=trueon every PR — including docs-only ones. Execution log showing the bug.This PR replaces the exclusion patterns with explicit positive includes for paths that actually affect generation:
scripts/**,gen.yaml,gen.lock,.speakeasy/**,.github/**,internal/**,go.mod,go.sum,main.go,provider/**.Review & Testing Checklist for Human
generate-command.ymlactually reads/writes.check-pathsjob should outputshould_run=falseand the validate job should be skipped (reported as "skipped", not "pending").Notes