Enable ruff to perform syntax upgrades#1325
Open
Vizonex wants to merge 5 commits intoaio-libs:masterfrom
Open
Conversation
for more information, see https://pre-commit.ci
Member
|
Definitely easier to review since only a few things need to be manually checked as we don't have to check each line of the pre-commit update. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1325 +/- ##
==========================================
- Coverage 99.86% 99.86% -0.01%
==========================================
Files 28 28
Lines 3607 3604 -3
Branches 265 265
==========================================
- Hits 3602 3599 -3
Misses 3 3
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bdraco
reviewed
Apr 22, 2026
Member
There was a problem hiding this comment.
I wonder why it didn't hit on this one
| def popone( | ||
| self, key: str, default: Union[_T, _SENTINEL] = sentinel | ||
| ) -> Union[_V, _T]: | ||
| def popone(self, key: str, default: _T) -> _V | _T: ... |
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This change enables ruff to make automatic upgrades when moving up versions of python or dropping versions (for example 3.9)
Are there changes in behavior for the user?
This should be helpful for other contributors and users.
Related issue number
#1324 this was discussed by me and @bdraco, I decided to branch out once again as this portion is a big enough change that requires another PR.
close #1324
Checklist