Update multidict/_multilib/state.h

Vizonex · bdraco · web-flow · commit 3ac82ec78467 · 2026-04-21T22:22:20.000-05:00
Co-authored-by: J. Nick Koston &lt;nick+github@koston.org&gt;
diff --git a/multidict/_multilib/state.h b/multidict/_multilib/state.h
@@ -130,10 +130,8 @@ get_mod_state_by_def(PyObject *self)
 static inline uint64_t
 NEXT_VERSION(mod_state *state)
 {
-    /* threads have the ability to screw with the global version,
-     * using an atomic variable ensures the global version is
-     * always accurate. */
-    return atomic_fetch_add(&state->global_version, 1) + 1;
+    /* relaxed is fine here as we only care about the atomicity of the RMW itself */
+    return atomic_fetch_add_explicit(&state->global_version, 1, memory_order_relaxed) + 1
 }
 
 #ifdef __cplusplus

Original file line number	Diff line number	Diff line change
`@@ -130,10 +130,8 @@ get_mod_state_by_def(PyObject *self)`
`130`	`130`	`static inline uint64_t`
`131`	`131`	`NEXT_VERSION(mod_state *state)`
`132`	`132`	`{`
`133`		`- /* threads have the ability to screw with the global version,`
`134`		`- * using an atomic variable ensures the global version is`
`135`		`- * always accurate. */`
`136`		`- return atomic_fetch_add(&state->global_version, 1) + 1;`
	`133`	`+ /* relaxed is fine here as we only care about the atomicity of the RMW itself */`
	`134`	`+ return atomic_fetch_add_explicit(&state->global_version, 1, memory_order_relaxed) + 1`
`137`	`135`	`}`
`138`	`136`
`139`	`137`	`#ifdef __cplusplus`