fine tune atomics to enusre all tests pass and add comment about why it's here

Vizonex · Vizonex · commit d9e4b0080549 · 2026-04-21T22:10:14.000-05:00
diff --git a/multidict/_multilib/state.h b/multidict/_multilib/state.h
@@ -130,9 +130,10 @@ get_mod_state_by_def(PyObject *self)
 static inline uint64_t
 NEXT_VERSION(mod_state *state)
 {
-    return atomic_fetch_add_explicit(
-               &state->global_version, 1, memory_order_relaxed) +
-           1;
+    /* threads have the ability to screw with the global version,
+     * using an atomic variable ensures the global version is
+     * always accurate. */
+    return atomic_fetch_add(&state->global_version, 1) + 1;
 }
 
 #ifdef __cplusplus

Original file line number	Diff line number	Diff line change
`@@ -130,9 +130,10 @@ get_mod_state_by_def(PyObject *self)`
`130`	`130`	`static inline uint64_t`
`131`	`131`	`NEXT_VERSION(mod_state *state)`
`132`	`132`	`{`
`133`		`- return atomic_fetch_add_explicit(`
`134`		`- &state->global_version, 1, memory_order_relaxed) +`
`135`		`- 1;`
	`133`	`+ /* threads have the ability to screw with the global version,`
	`134`	`+ * using an atomic variable ensures the global version is`
	`135`	`+ * always accurate. */`
	`136`	`+ return atomic_fetch_add(&state->global_version, 1) + 1;`
`136`	`137`	`}`
`137`	`138`
`138`	`139`	`#ifdef __cplusplus`