Merged
Conversation
1d12ea7 to
151c09c
Compare
151c09c to
ba2c2a2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #733 +/- ##
=======================================
Coverage 97.37% 97.37%
=======================================
Files 15 15
Lines 991 991
Branches 56 56
=======================================
Hits 965 965
Misses 23 23
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
there are some opportunities of refactoring in the benchmark code. But I've kept the changes to the minimum necessary to fix the issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fixed two logic bugs in
benchmark.pythat prevented accurate performance measurements:test_cache_miss_benchmarkwas previously improperly configured with only 128 distinct objects (matching the cache size), resulting in cache hits instead of misses. Increased the sample size to 2048 objects to ensure evictions and actual misses are measured.test_concurrent_cache_hit_benchmarkcontained a bug where the loop returned after the first iteration. Removed the premature return to ensure the benchmark runs for the intended 10 iterations.Are there changes in behavior for the user?
No. These changes only affect the internal benchmark suite used for performance verification.
Related issue number
N/A
Checklist