Add Concatenate to Paramspec so that Class Methods get correctly defined#639
Closed
Vizonex wants to merge 2 commits intoaio-libs:paramspecfrom
Vizonex:patch-3
Closed
Add Concatenate to Paramspec so that Class Methods get correctly defined#639Vizonex wants to merge 2 commits intoaio-libs:paramspecfrom Vizonex:patch-3
Vizonex wants to merge 2 commits intoaio-libs:paramspecfrom
Vizonex:patch-3
Conversation
Member
|
Thanks, I'll try and look at this next week. |
Member
Author
No Problem, take your time. |
Member
|
This seems to create more errors. paramspec has 16 type errors in mypy, this branch has 85. |
Member
|
Progress is on #508, so any further attempt to use Concatenate will require branching off that again and creating a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I Added Concenate to Paramspec to Fix Some Behaviors with Typehinting Class Methods inside VS Code and hopefully other ides
These changes correctly type hint the parameters inside of the asynchronous functions when throwing in parameters allowing pywright to properly hint at what to put into the function.
Here's an example of it working on my pc for class-methods

Related issue number
Checklist