Skip to content

Add Concatenate to Paramspec so that Class Methods get correctly defined#639

Closed
Vizonex wants to merge 2 commits intoaio-libs:paramspecfrom
Vizonex:patch-3
Closed

Add Concatenate to Paramspec so that Class Methods get correctly defined#639
Vizonex wants to merge 2 commits intoaio-libs:paramspecfrom
Vizonex:patch-3

Conversation

@Vizonex
Copy link
Copy Markdown
Member

@Vizonex Vizonex commented Jan 24, 2025

I Added Concenate to Paramspec to Fix Some Behaviors with Typehinting Class Methods inside VS Code and hopefully other ides

These changes correctly type hint the parameters inside of the asynchronous functions when throwing in parameters allowing pywright to properly hint at what to put into the function.

Here's an example of it working on my pc for class-methods
image

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@Dreamsorcerer
Copy link
Copy Markdown
Member

Thanks, I'll try and look at this next week.

@Vizonex
Copy link
Copy Markdown
Member Author

Vizonex commented Jan 24, 2025

Thanks, I'll try and look at this next week.

No Problem, take your time.

@Dreamsorcerer
Copy link
Copy Markdown
Member

This seems to create more errors. paramspec has 16 type errors in mypy, this branch has 85.

@Dreamsorcerer
Copy link
Copy Markdown
Member

Dreamsorcerer commented Mar 16, 2025

Progress is on #508, so any further attempt to use Concatenate will require branching off that again and creating a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants