Switch from asyncio.iscoroutinefunction to inspect.#637
Switch from asyncio.iscoroutinefunction to inspect.#637Dreamsorcerer merged 22 commits intoaio-libs:masterfrom
Conversation
|
3.14 is still failing due to the same function call happening in pytest-asyncio. |
2a84d89 to
ec1c2b9
Compare
The former causes: DeprecationWarning: 'asyncio.iscoroutinefunction' is deprecated and slated for removal in Python 3.16; use inspect.iscoroutinefunction() instead. Fixes: aio-libs#635
ec1c2b9 to
c2a83bb
Compare
|
I've implemented it in a way that older Pythons use the old way. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #637 +/- ##
==========================================
+ Coverage 96.88% 97.00% +0.11%
==========================================
Files 12 12
Lines 770 800 +30
Branches 91 41 -50
==========================================
+ Hits 746 776 +30
Misses 22 22
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Ah, Dependabot got stuck from 3.8 still being in the tests. Let me clear the Dependabot PRs quickly, which will get us an updated pytest-asyncio. |
|
Looks like pytest-asyncio still needs some updates. Now it's |
|
Reported: pytest-dev/pytest-asyncio#1049 |
|
Doesn't look like it'll be fixed for a while, so we should probably ignore the warning in pytest-asyncio. |
|
That's pytest-asyncio ignored, but still get 4 failures as it seems that the inspect function is still not equivalent of the asyncio one... |
|
That's actually one more failure than we saw on older releases, suggesting the inspect function is actually less compatible in 3.14 than previous releases. |
The former causes: DeprecationWarning:
'asyncio.iscoroutinefunction' is deprecated and slated for removal in Python 3.16; use inspect.iscoroutinefunction() instead.
Fixes: #635
What do these changes do?
See the description in the commit message.
Are there changes in behavior for the user?
No
Related issue number
#635
Checklist