fix: handle OSError from getpass.getuser on Python 3.13+#1074
Open
armorbreak001 wants to merge 1 commit intoaio-libs:mainfrom
Open
fix: handle OSError from getpass.getuser on Python 3.13+#1074armorbreak001 wants to merge 1 commit intoaio-libs:mainfrom
armorbreak001 wants to merge 1 commit intoaio-libs:mainfrom
Conversation
Python 3.13 changed getpass.getuser() to raise OSError instead of KeyError when the UID has no matching username entry (e.g. in containers with numeric UIDs). Catch both for compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Python 3.13 changed
getpass.getuser()to raiseOSErrorinstead ofKeyErrorwhen the UID has no matching username entry (e.g. in containers with numeric UIDs, see bpo-32731). The current code only catchesKeyError, so importing aiomysql crashes on Python 3.13+ in such environments.This mirrors the fix applied to PyMySQL in PyMySQL/PyMySQL@a1ac823.
Details
Before: Import fails with
OSErroron Python 3.13+ when UID is unmappedAfter: Gracefully falls back to
"unknown"user, same as the existing KeyError pathFixes #1053