perf: optimize MessageBatch.wait_drain() to avoid asyncio.wait overhead#1144
Open
gloryfromca wants to merge 1 commit intoaio-libs:masterfrom
Open
perf: optimize MessageBatch.wait_drain() to avoid asyncio.wait overhead#1144gloryfromca wants to merge 1 commit intoaio-libs:masterfrom
gloryfromca wants to merge 1 commit intoaio-libs:masterfrom
Conversation
Replace asyncio.wait([single_future]) with async_timeout.timeout() for better performance in high-frequency scenarios. The original implementation using asyncio.wait() for a single future is inefficient because it creates sets and registers/removes callbacks on each call. Using async_timeout directly eliminates this overhead. Performance improvement (tested): - P90 latency: 479ms, 469ms -> 296ms, 299ms (~37% reduction) - QPS: 111, 107 -> 142, 142 (~30% increase)
Author
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Replace asyncio.wait([single_future]) with async_timeout.timeout() for better performance in high-frequency scenarios.
The original implementation using asyncio.wait() for a single future is inefficient because it creates sets and registers/removes callbacks on each call. Using async_timeout directly eliminates this overhead.
Performance improvement (tested):
Changes
Fixes #
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.