fix: make AIOKafkaProducer.start() idempotent to prevent busy loop#1143
Open
gloryfromca wants to merge 1 commit intoaio-libs:masterfrom
Open
fix: make AIOKafkaProducer.start() idempotent to prevent busy loop#1143gloryfromca wants to merge 1 commit intoaio-libs:masterfrom
gloryfromca wants to merge 1 commit intoaio-libs:masterfrom
Conversation
When start() is called multiple times on the same producer instance (e.g., by multiple listeners sharing the same producer), each call would create a new sender task. Multiple sender tasks sharing the same message accumulator causes them to wake each other up via drain_by_nodes(), resulting in an infinite busy loop. Changes: - Add _started flag to track producer startup state - Return early if start() is called on an already-started producer - Reset _started flag on startup failure to allow retry This ensures only one sender task is created per producer instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When start() is called multiple times on the same producer instance (e.g., by multiple listeners sharing the same producer), each call would create a new sender task. Multiple sender tasks sharing the same message accumulator causes them to wake each other up via drain_by_nodes(), resulting in an infinite busy loop.
Changes:
This ensures only one sender task is created per producer instance.
Changes
Fixes #
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.