Add support for rack id in the consumer#1107
Open
vbhavsar wants to merge 4 commits intoaio-libs:masterfrom
Open
Add support for rack id in the consumer#1107vbhavsar wants to merge 4 commits intoaio-libs:masterfrom
vbhavsar wants to merge 4 commits intoaio-libs:masterfrom
Conversation
Author
vbhavsar
commented
May 12, 2025
Comment on lines
+402
to
+405
| session_id=0, | ||
| session_epoch=-1, | ||
| forgotten_topics_data=None, | ||
| rack_id="", |
Author
There was a problem hiding this comment.
Default values derived from https://github.com/a0x8o/kafka/blob/master/clients/src/main/resources/common/message/FetchRequest.json
korjek
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Changes
rack_idparameter on AIOKafkaConsumer and store it on the instance.rack_id(alongside new session metadata fieldssession_id,session_epochandforgotten_topics_data) into the internalFetcher.rack_idin the payloadFixes #1016
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.