fix(multipart): ensure BodyPartReader.read() returns bytes not bytearray#12412
Closed
armorbreak001 wants to merge 1 commit intoaio-libs:masterfrom
Closed
fix(multipart): ensure BodyPartReader.read() returns bytes not bytearray#12412armorbreak001 wants to merge 1 commit intoaio-libs:masterfrom
armorbreak001 wants to merge 1 commit intoaio-libs:masterfrom
Conversation
The read() method accumulated data in a bytearray but returned it directly, violating the documented return type annotation (bytes). This caused TypeError when passing the result to json.dumps or other APIs that expect bytes rather than bytearray.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BodyPartReader.read() accumulates data in an internal bytearray buffer but returns it directly without converting to bytes. This violates the documented return type annotation (bytes) and causes TypeError in downstream code that passes the result to json.dumps() or any API expecting bytes rather than bytearray.
The fix wraps both return paths with bytes() so the returned type always matches the annotation.
Fixes #12404