Fix NK fertiliser high-pH NH3 EF using wrong list index (7=MAP → 8=NK)#9
Open
mklarmann wants to merge 1 commit into
Open
Fix NK fertiliser high-pH NH3 EF using wrong list index (7=MAP → 8=NK)#9mklarmann wants to merge 1 commit into
mklarmann wants to merge 1 commit into
Conversation
The fertiliser list is 0-indexed as 7=MAP, 8=NK. Every ef_* pair uses the same index on the low-pH and high-pH lists except NK, whose high-pH term used index 7 (MAP) while the low-pH term correctly used 8 (NK). For NK fertilisers at higher soil pH this took the high-pH contribution from MAP instead of NK. Use index 8. Fixes agroscope-ch#4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fertiliser list is 0-indexed as 7=MAP, 8=NK. Every
ef_*pair uses the same index on the low-pH and high-pH lists except NK, whose high-pH term used index 7 (MAP) while the low-pH term correctly used 8 (NK). For NK fertilisers at higher soil pH this took the high-pH contribution from MAP instead of NK. This uses index 8.Fixes #4