Fix c_month() ignoring its input (always returned all-zeros)#8
Open
mklarmann wants to merge 1 commit into
Open
Fix c_month() ignoring its input (always returned all-zeros)#8mklarmann wants to merge 1 commit into
mklarmann wants to merge 1 commit into
Conversation
c_month() initialised m_month to np.zeros and then tested m_month[i] (the zeros it had just created) instead of the input months, so no branch ever fired and the function returned an all-zeros array regardless of its argument — silently disabling the tillage month-correction. Seed m_month from in_month so the Dec/Jan -> February remapping operates on the real event months. Fixes agroscope-ch#3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c_month()initialisedm_monthtonp.zerosand then testedm_month[i](the zeros it had just created) instead of the input months, so no branch ever fired and the function returned an all-zeros array regardless of its argument — silently disabling the tillage month-correction. This seedsm_monthfromin_monthso the Dec/Jan → February remapping operates on the real event months.Fixes #3