Fix no-op N/TAN loss-rate clamps (min result discarded)#7
Open
mklarmann wants to merge 1 commit into
Open
Conversation
The min(1.0, loss_rate_N_frac) / min(1.0, loss_rate_TAN_frac) calls computed a
value that was discarded (no assignment), so the intended clamp ('cannot be >1')
had no effect and loss rates could exceed 1.0. Assign the result back.
Fixes agroscope-ch#2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
min(1.0, loss_rate_N_frac)andmin(1.0, loss_rate_TAN_frac)calls inSALCAfield_field.py(lines 861, 870) computed a value that was discarded, so the intended clamp ("cannot be >1") had no effect and the loss rates could exceed 1.0 and flow uncapped into SALCAnitrate. This assigns the result back.Fixes #2