Fix waterRegimeCode group_9 check comparing against ' z' (leading space)#11
Open
mklarmann wants to merge 1 commit into
Open
Fix waterRegimeCode group_9 check comparing against ' z' (leading space)#11mklarmann wants to merge 1 commit into
mklarmann wants to merge 1 commit into
Conversation
group_9 maps to ['z'], so watRegSel[0] == 'z', but the special-case compared
against ' z' (leading space) and was never true. As a result group_9 soils fell
through to the bound-interval branch, where bound.get('z') is None and
searchintervals(None, ...) raises. Remove the leading space so group_9 is handled.
Fixes agroscope-ch#6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
group_9maps to['z'], sowatRegSel[0] == 'z', but the special-case compared against' z'(leading space) and was never true. As a result group_9 soils fell through to the bound-interval branch, wherebound.get('z')isNoneandsearchintervals(None, ...)raises. This removes the leading space so group_9 is handled.Fixes #6