fix: case-insensitive extension validation and robust language detection (fixes #685)#687
Merged
Merged
Conversation
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issues with file extension validation and language detection, particularly on case-insensitive file systems like Windows.
Fixes #685
Changes:
isValidLanguageandgetLanguageto normalize extensions to lowercase before checking. This fixes issues where files likef.CPPwere incorrectly flagged as unsupported.getLanguageto correctly handle extensions like.ccand.cxxby checking both language keys and supported extension values in the config.checkUnsupportedto provide a specific "No active editor found" message when no file is active, instead of the misleading "Unsupported file extension" error.These changes improve the user experience and prevent confusing errors during file renaming or creation.