Add configurable Codeforces filename styles#673
Open
Naf66 wants to merge 7 commits into
Open
Conversation
agrawal-d
requested changes
Jun 2, 2026
| "shortcode", | ||
| "both" | ||
| ], | ||
| "description": "Choose how Codeforces problem files are named: name, shortcode, both, or legacy." |
Owner
There was a problem hiding this comment.
Needs more details.
- In short in the settings description what each type means.
- In detail in the user guide markdown with examples.
| } | ||
| if (isCodeforcesUrl(new URL(problem.url)) && useShortCodeForcesName()) { | ||
| return `${getProblemName(problem.url)}.${ext}`; | ||
| if (isCodeforcesUrl(new URL(problem.url))) { |
Owner
There was a problem hiding this comment.
Add unit tests to check input details and expected output problem name for each type of setting.
Author
|
Thanks for the review! I've addressed the feedback: Added detailed description and also added localization as other settings for the 4 languages I also extracted the filename generation logic into a small helper to make it easier to unit test. All tests and lint checks are passing now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing
Tested locally with multiple Codeforces problems and verified:
Additional checks performed:
npm run lintnpm run testnpm run test-compilenpm run vscode:prepublishAll checks completed successfully.
Future Extensions
The implementation is intentionally structured around a naming style setting, making it straightforward to add similar configurable filename styles for other platforms (e.g. AtCoder) in the future if desired.