feat(controller): expose spec.env through REST API - #1096
Open
shenjiecode wants to merge 4 commits into
Open
Conversation
Signed-off-by: Jay Shen <[email protected]>
Signed-off-by: Jay Shen <[email protected]>
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Author
|
Hi @shiyiyue1102 👋 Quick context: this follows up on the REST/CLI surface that #690 intentionally deferred — it carries Since this is my first contribution to the repo, branch protection is holding a couple of things up. Could you help with:
The branch has no conflicts with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up on the REST/CLI work intentionally deferred by #690.
WorkerSpec.EnvandManagerSpec.Envalready exist in the CRD and are merged into container environments, but the public REST create/update DTOs do not carry them. As a result,agt apply -faccepts manifests containingspec.envand forwards the field to the REST API, where it is currently ignored.This PR:
envthrough Worker and Manager REST create/update requests;env: {};agt apply -fYAML projection regression;The existing system-wins collision policy and controller-to-backend propagation are unchanged.
Verification
go test ./internal/... ./cmd/...make test-integration