fix(migrate): analyze current cron job format - #1049
Merged
shiyiyue1102 merged 2 commits intoJul 17, 2026
Conversation
shiyiyue1102
approved these changes
Jul 17, 2026
shiyiyue1102
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. The analyzer now supports both the current object-wrapped cron format and the legacy top-level array, and empty dependency categories serialize as real empty arrays. The change is scoped, includes focused regression coverage, and the required check is green.
nattiini45
added a commit
to nattiini45/AgentTeams
that referenced
this pull request
Jul 23, 2026
* fix: align AgentTeams runtime naming defaults (agentscope-ai#1041) * fix: prepare beta release workflow (agentscope-ai#1054) * fix: harden beta release gates (agentscope-ai#1056) * fix(cli): reject unsafe plugin archive links (agentscope-ai#1043) * fix(scripts): redact complete Matrix events (agentscope-ai#1047) * fix(migrate): analyze current cron job format (agentscope-ai#1049) * fix(migrate): print runnable ZIP import command (agentscope-ai#1048) * fix(replay): capture immediate manager replies (agentscope-ai#1045) * fix(hack): persist containerized skopeo auth (agentscope-ai#1050) * chore: archive changelog for v1.2.0-beta.1 (agentscope-ai#1058) Co-authored-by: shiyiyue1102 <[email protected]> * fix(copaw): route Team Leader assignments to Team Room (agentscope-ai#1060) * fix(install): user can specify which docker.sock to mount when run install script (agentscope-ai#553) * docs: clarify Element homeserver port (agentscope-ai#978) Co-authored-by: Ziyang Guo <[email protected]> * docs: clarify Higress AI route matching (agentscope-ai#980) Co-authored-by: Ziyang Guo <[email protected]> * docs: clarify OpenAI-compatible provider setup (agentscope-ai#1013) * refactor: complete AgentTeams runtime rename (agentscope-ai#1063) * refactor: complete the AgentTeams hard-cut rename (agentscope-ai#1065) * docs: add v1.2.0-beta.1 release news (agentscope-ai#1066) * feat(sync): restore fork-only product trees on agentteams paths Replay dashboard Helm templates under helm/agentteams, dashboard values and helpers, qwenpaw worker image defaults, and path-adapted remediation-gates (agentteams-controller / helm/agentteams). Root dashboard/, shared/python/, openwiki/, and Gastown skills already survived the merge baseline. Co-authored-by: Cursor <[email protected]> * feat(controller): port fork Project CRD, health, APIs, and status CLI Replay fork-only agentteams-controller features onto the upstream rename baseline: Project CRD/reconciler/Helm, health monitor, message and manager-tasks APIs, worker health probes, managerstate CLI, enhanced agt status overview, SoloOperator/QwenPaw/docker resource wiring, and related tests. Co-authored-by: Cursor <[email protected]> * feat(runtimes): restore quiet-rooms and Higress extra-provider prefix strip Keep upstream CoPaw Team Leader DM-to-Team-Room routing while replaying fork AGENTTEAMS_QUIET_ROOMS bridge/channel wiring. Restore OPT-IN AGENTTEAMS_EXTRA_LLM_PROVIDERS setup with modelMapping prefix strip in setup-higress.sh (route names agentteams-*-route). Co-authored-by: Cursor <[email protected]> * docs(sync): truth-up migration doc, merge changelog, agt naming sweep Rewrite upstream-integration-migration.md for rename acceptance + fork overlay DoD (drop dual-CRD/HICLAW_* claims). Merge changelog entries from both sides. Point pre-commit and openwiki paths at agentteams-controller / helm/agentteams. Align agent-facing CLI examples to agt. Co-authored-by: Cursor <[email protected]> * fix(qwenpaw): resolve Windows file:// agent package refs urlparse puts file://C:\path entirely in netloc with an empty path; Path('') became cwd and silently copied the repo instead of the package archive. Co-authored-by: Cursor <[email protected]> * fix(ci): purge brand leftovers and restore fork runtime bridge/sync Clear remaining retired-brand strings/paths so helm-lint rename gate passes, restore CoPaw fork bridge/worker APIs and Hermes thin sync semantics, and harden installer prompt helpers with printf -v. Co-authored-by: Cursor <[email protected]> * fix(copaw): restore Matrix channel APIs and thin sync wrapper Bring back fork Matrix channel behavior needed by worker tests, switch sync back to the agentteams_sync wrapper, and share filesync helpers via _toolhelpers. Co-authored-by: Cursor <[email protected]> * fix(sync): restore agentteams- bucket prefix stripping for team storage The rename pass incorrectly shortened the hiclaw- bucket prefix check to agt-, breaking team path derivation for agentteams-* buckets. Co-authored-by: Cursor <[email protected]> * fix(security): remediate Kilo review findings on sync/upstream-main Harden appservice token compare, proxy body limits, lifecycle error logging, Helm image/RBAC/CRD alignment, OpenHuman TOML escaping, and storage alias safety. Co-authored-by: Cursor <[email protected]> * fix(helm): avoid retired brand in storage.bucket comment Rename gate rejects hiclaw tokens even in comments; keep migration note brand-free. Co-authored-by: Cursor <[email protected]> --------- Co-authored-by: shiyiyue1102 <[email protected]> Co-authored-by: Ziyang Guo <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: shiyiyue1102 <[email protected]> Co-authored-by: Daniel Qian <[email protected]> Co-authored-by: Ziyang Guo <[email protected]> Co-authored-by: Cursor <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jobsarray[], not[""]Problem
generate-zip.shalready documents the current cron schema as{"version":1,"jobs":[...]}, butanalyze.shstill evaluates.[].payload...as if the root were a job array. jq errors are intentionally suppressed by the heuristic scanner, so current-format cron commands silently disappear fromtool-analysis.jsonand their required binaries are omitted from migration planning.The JSON serialization also pipes empty Bash arrays through
printf, which emits one blank line and turns every empty dependency category into[""]. That pollutes the analysis report and downstream migration manifest with a fake package/binary entry.Testing
cron_payload_commands: 0and misses the cron-only binary on currentmain[""]for apt, pip, npm, and unknown binaries; the fixed output uses[]bash migrate/skill/tests/test-analyze-cron.shshellcheck -S warning migrate/skill/tests/test-analyze-cron.shbash -n migrate/skill/scripts/analyze.sh migrate/skill/tests/test-analyze-cron.shgit diff --checkThe test verifies current object-wrapped jobs, legacy top-level arrays, and an environment with no detected dependencies. This is separate from #1048, which only corrects the final generated import command.