fix: report npm bridge transport errors - #36
Merged
Conversation
|
Deployment #103 deployed successfully
Deployed on Manufact.com |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The bridge did not install client.onerror or server.onerror handlers. Errors delivered through those SDK callbacks therefore had no diagnostic output, leaving operators without the underlying hosted or stdio failure.
This PR deliberately does not claim to fix silent process exit. The real Streamable HTTP transport does not emit onclose for network failures. A POST SSE response that ends cleanly without a JSON-RPC response can also remain pending until the SDK request timeout; that SDK-level behavior is outside this observability patch.
Testing