Package hygiene: per-package LICENSE, engines, tsbuildinfo out of dist, dep fixes (#42)#47
Open
davidcrowe wants to merge 1 commit into
Open
Package hygiene: per-package LICENSE, engines, tsbuildinfo out of dist, dep fixes (#42)#47davidcrowe wants to merge 1 commit into
davidcrowe wants to merge 1 commit into
Conversation
…t, dep fixes (#42) Class-level packaging defects from the 2026-07-23 sweep, across the 13 published packages. - **LICENSE shipped in zero tarballs.** Every package.json lists "LICENSE" in `files`, but the file existed only at repo root — npm only auto-includes LICENSE from the package dir, so every tarball claimed MIT and shipped no license. Added a per-package LICENSE (copy of root) and ensured "LICENSE" (and README.md where present) is in each `files` list. `npm pack --dry-run` now shows LICENSE in the tarball. - **tsconfig.tsbuildinfo shipped in dist** of the 10 packages that set `tsBuildInfoFile: dist/...` — a dead dev file in every tarball. Moved it to the package root (`tsconfig.tsbuildinfo`), which is outside the `files` whitelist, so it no longer ships. Verified no *.tsbuildinfo remains in any dist. (Already covered by .gitignore, so none get tracked.) - **No `engines` field anywhere** despite ESM-only + global-fetch reliance. Added `"node": ">=18"` to all published packages. - **request-context / observability-core had no prepublishOnly build** — stale-dist publish risk. Added `prepublishOnly: npm run build` wherever a build script exists but the hook was missing. - **proxyabl pinned request-context exactly** (`0.0.6`) while identifiabl uses `^` — a future request-context patch would force a proxyabl republish. Loosened to `^0.0.6`. - **identifiabl declared unused `jose@^5`** — its source/dist never import jose (only a stale doc comment referenced it), and it caused a dual-jose install (5.x hoisted + 6.x under core). Dropped it. Build clean, full suite 159 green. Out of scope here (flagged): the transformabl facade range ^0.3.0 -> ^0.4.1 is handled in the 0.4.1 release PR (#45). The four declared-but-unused deps in the "badge-padding" item live in gatewaystack-connect (the prod repo), not here. Also noted: packages/explicabl-core/ contains the package NAMED @gatewaystack/observability-core — a dir/name mismatch worth a follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42. Class-level packaging defects across the 13 published packages.
package.jsonlists"LICENSE"infiles, but the file existed only at repo root — npm only auto-includes LICENSE from the package dir, so every tarball claimed MIT and shipped none. Added a per-package LICENSE (copy of root) and ensuredLICENSE(+README.mdwhere present) is in eachfileslist.npm pack --dry-runnow shows LICENSE in the tarball.tsconfig.tsbuildinfoshipped in dist of the 10 packages that settsBuildInfoFile: dist/…— a dead dev file in every tarball. Moved it to the package root (outside thefileswhitelist), so it no longer ships. Verified no*.tsbuildinforemains in anydist.enginesfield anywhere — added"node": ">=18"to all published packages.prepublishOnlybuild onrequest-context/observability-core(stale-dist publish risk) — added where abuildscript exists.0.0.6) — loosened to^0.0.6so a request-context patch doesn't force a proxyabl republish.jose@^5— source/dist never import it (only a stale doc comment did), and it caused a dual-jose install. Dropped.npm run buildclean · full suite 159 green ·npm pack --dry-runverified (LICENSE in, tsbuildinfo out).Out of scope (flagged, not done here)
^0.3.0→^0.4.1is handled in the 0.4.1 release PR transformabl-core 0.4.1: redactPii overlap fix (H4) + scan-truncation flag (M2) #45 (doing it here too would conflict).packages/explicabl-core/contains the package named@gatewaystack/observability-core— a directory/name mismatch.Versions not bumped — publish/versioning is your step (OTP). Not merged.