fix(proxyabl): declare jose as a runtime dependency#35
Open
davidcrowe wants to merge 1 commit into
Open
Conversation
@gatewaystack/proxyabl-core imports jose in auth.ts and oidc.ts but never declared it, so a fresh npm install of the published package failed on first import with ERR_MODULE_NOT_FOUND — it only worked inside this monorepo, where jose is hoisted from identifiabl-core. Pin ^6.1.0 to match identifiabl-core, bump core to 0.1.1 and middleware to 0.0.13, and give the middleware a jose devDependency for its type-only import so it typechecks outside the workspace.
This was referenced Jul 23, 2026
Collaborator
Author
|
Reviewed + confirmed green (build + test SUCCESS, MERGEABLE/CLEAN). Verified the jose classification is correct: @davidcrowe — needs your merge + republish (OTP): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
@gatewaystack/[email protected]importsjose(src/auth.ts:2,src/oidc.ts:7) but declares no dependencies at all, so the published package is broken on fresh install:It only works inside this monorepo because
joseis hoisted fromidentifiabl-core.@gatewaystack/proxyablinherits the breakage through its dependency on core.Fix
proxyabl-core: addjose@^6.1.0todependencies(matchesidentifiabl-core), bump to 0.1.1proxyabl: bump core constraint to^0.1.1, addjosetodevDependencies(its import is type-only — erased at runtime, needed for standalone typechecking), bump to 0.0.13Verification
npm packthe fixed core, install the tarball in an empty directory, import — succeeds with 17 exports (josepulled from the registry as a declared dep)Both packages need a republish after merge (
prepublishOnlyhandles the build).