Fix numba failure in systems where numpy asytpe(int) is int64#25
Open
yuval-ngtnuma wants to merge 1 commit into
Open
Fix numba failure in systems where numpy asytpe(int) is int64#25yuval-ngtnuma wants to merge 1 commit into
yuval-ngtnuma wants to merge 1 commit into
Conversation
On systems where NumPy astype(int) uses int64, the following error occurs:
numba.core.errors.TypingError: Failed in nopython mode pipeline (step: nopython frontend)
Cannot unify array(int64, 2d, C) and array(int32, 2d, C) for 'swt_matrix.2', defined at ../venv/lib/python3.10/site-packages/swtloc/core.py (126)
```
File "../venv/lib/python3.10/site-packages/swtloc/core.py", line 126:
def swt_strokes(edged_image,
<source elided>
_ray_ix = ray_indices[:ray_pointer, 1]
for each_y, each_x in zip(_ray_iy, _ray_ix):
^
```
This is due to Numba trying to figure out the type of `swt_matrix` in `swt_strokes`, but it can be either case of the if (Numba doesn't check the actual value provided to `include_edges_in_swt` before it determines the types)
```
# ...
if include_edges_in_swt:
swt_matrix = edged_image.copy()
else:
swt_matrix = np.zeros(shape=edged_image.shape, dtype=np.int32)
# ...
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On systems where NumPy astype(int) uses int64, the following error occurs:
numba.core.errors.TypingError: Failed in nopython mode pipeline (step: nopython frontend) Cannot unify array(int64, 2d, C) and array(int32, 2d, C) for 'swt_matrix.2', defined at ../venv/lib/python3.10/site-packages/swtloc/core.py (126)
This is due to Numba trying to figure out the type of
swt_matrixinswt_strokes, but it can be either case of the if (Numba doesn't check the actual value provided toinclude_edges_in_swtbefore it determines the types)