Please consider the following formatting changes to #16228#18
Closed
alibuild wants to merge 3 commits into
Closed
Conversation
The interface for the ML-based matching has changed and requires additional tables for the tracks and collision, which are not yet included in the tableMaker code. Since the ML-based matching is still experimental and not intended for physics analysis, the skimming code based on the ML output is disabled for the moment, waiting for a proper fix for the missing tables.
Some of the input features supported by the DQ MLResponse class are optional by checking the availability of the corresponding getter function at compile time. If the getter is unavailable because the corresponding dynamic table is not joined, the feature is set to zero.
aferrero2707
force-pushed
the
PWGDQ-matching-extend-ml-input-features
branch
from
055f746 to
7123683
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your PR AliceO2Group#16228 cannot be merged as is. You should either run
clang-formatyourself and update the pull request, or merge this PR in yours.You can find the AliceO2 coding conventions at https://github.com/AliceO2Group/CodingGuidelines.