Add target meta ability#13
Merged
Merged
Conversation
Also renamed concrete class to "Address" because IDE / eslint has issues resolving the type when implementing an aliased interface.
There was no reason for using that util, in this case.
This should use slightly less memory, then before.
This should avoid unnecessary memory allocation for member address, if one was previously already created.
NOTE: this does NOT work for overridden static members. We still need some kind of `@inheritMeta()` decorator / helper to ensure this can become available for developers.
Remaining tests are located in the "meta static members" tests.
The "version" should not be needed, when the package.json has "packageManager" specified with version specified.
Unsure if lint command fails because of missing builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR adds the ability to retrieve metadata using a class member reference. This does also work on static members, provided that they are not overridden. When a static member is overridden, then a new
@inheritMeta()decorator can be used to register an internal owner / member address, which then enables developers to obtain metadata using member reference.See tests for additional information.