Skip to content

Remove paid tag & update file icons#893

Merged
thostetler merged 3 commits into
adsabs:masterfrom
shinyichen:remove-paid-tag
Jun 22, 2026
Merged

Remove paid tag & update file icons#893
thostetler merged 3 commits into
adsabs:masterfrom
shinyichen:remove-paid-tag

Conversation

@shinyichen

Copy link
Copy Markdown
Member
Screenshot 2026-06-22 at 10 49 34 AM Screenshot 2026-06-22 at 10 50 07 AM

@shinyichen shinyichen requested a review from thostetler June 22, 2026 17:50
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 68.90756% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.9%. Comparing base (0b8bc82) to head (24c3537).

Files with missing lines Patch % Lines
src/components/icons/ScanFileIcon.tsx 19.4% 25 Missing ⚠️
src/components/icons/GenericFileIcon.tsx 0.0% 8 Missing ⚠️
...components/AbstractSources/AbstractSourceItems.tsx 63.7% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #893     +/-   ##
========================================
- Coverage    65.9%   65.9%   -0.0%     
========================================
  Files         336     337      +1     
  Lines       39860   39954     +94     
  Branches     2006    2004      -2     
========================================
+ Hits        26250   26308     +58     
- Misses      13567   13604     +37     
+ Partials       43      42      -1     
Files with missing lines Coverage Δ
src/components/AbstractSources/accessLabel.ts 100.0% <100.0%> (ø)
src/components/icons/HtmlFileIcon.tsx 100.0% <100.0%> (ø)
src/components/icons/PdfFileIcon.tsx 100.0% <100.0%> (ø)
...components/AbstractSources/AbstractSourceItems.tsx 82.9% <63.7%> (-<0.1%) ⬇️
src/components/icons/GenericFileIcon.tsx 40.0% <0.0%> (-26.6%) ⬇️
src/components/icons/ScanFileIcon.tsx 19.4% <19.4%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thostetler thostetler left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thostetler thostetler merged commit b3e8eb0 into adsabs:master Jun 22, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants