Skip to content

add volume and page in search result items#892

Open
shinyichen wants to merge 1 commit into
adsabs:masterfrom
shinyichen:SCIX-833-add-vol-and-page-count
Open

add volume and page in search result items#892
shinyichen wants to merge 1 commit into
adsabs:masterfrom
shinyichen:SCIX-833-add-vol-and-page-count

Conversation

@shinyichen

Copy link
Copy Markdown
Member
Screenshot 2026-06-22 at 10 40 31 AM

@shinyichen shinyichen requested a review from thostetler June 22, 2026 17:41
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.9%. Comparing base (0b8bc82) to head (1795398).

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #892     +/-   ##
========================================
- Coverage    65.9%   65.9%   -0.0%     
========================================
  Files         336     335      -1     
  Lines       39860   39813     -47     
  Branches     2006    2006             
========================================
- Hits        26250   26209     -41     
+ Misses      13567   13561      -6     
  Partials       43      43             
Files with missing lines Coverage Δ
src/api/search/models.ts 47.5% <100.0%> (+0.5%) ⬆️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thostetler thostetler left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, I just had the one suggestion

divider={divider}
>
<Text>{formattedPubDate}</Text>
<Text>{truncatedPub}</Text>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Text>{truncatedPub}</Text>
<Tooltip
label={pub}
aria-label="publication tooltip"
placement="top"
isDisabled={!pub || pub.length <= APP_DEFAULTS.RESULT_ITEM_PUB_CUTOFF}
>
<Text>{truncatedPub}</Text>
</Tooltip>

Wonder if we should allow expanding the full pub name for when it gets truncated?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would need to be duplicated in the library too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants