add volume and page in search result items#892
Open
shinyichen wants to merge 1 commit into
Open
Conversation
shinyichen
commented
Jun 22, 2026
Member
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #892 +/- ##
========================================
- Coverage 65.9% 65.9% -0.0%
========================================
Files 336 335 -1
Lines 39860 39813 -47
Branches 2006 2006
========================================
- Hits 26250 26209 -41
+ Misses 13567 13561 -6
Partials 43 43
🚀 New features to boost your workflow:
|
thostetler
approved these changes
Jun 22, 2026
thostetler
left a comment
Member
There was a problem hiding this comment.
Looks great to me, I just had the one suggestion
| divider={divider} | ||
| > | ||
| <Text>{formattedPubDate}</Text> | ||
| <Text>{truncatedPub}</Text> |
Member
There was a problem hiding this comment.
Suggested change
| <Text>{truncatedPub}</Text> | |
| <Tooltip | |
| label={pub} | |
| aria-label="publication tooltip" | |
| placement="top" | |
| isDisabled={!pub || pub.length <= APP_DEFAULTS.RESULT_ITEM_PUB_CUTOFF} | |
| > | |
| <Text>{truncatedPub}</Text> | |
| </Tooltip> |
Wonder if we should allow expanding the full pub name for when it gets truncated?
Member
There was a problem hiding this comment.
this would need to be duplicated in the library too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.