This repository was archived by the owner on Sep 4, 2020. It is now read-only.
#35 WIP: try to use child_added event to avoid updating whole array for single item being added#37
Open
ciekawy wants to merge 1 commit into
Open
Conversation
… whole array for single item being added
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
==========================================
- Coverage 97.8% 93.92% -3.89%
==========================================
Files 6 6
Lines 319 329 +10
Branches 45 46 +1
==========================================
- Hits 312 309 -3
- Misses 7 20 +13
Continue to review full report at Codecov.
|
Owner
|
I really like what I see so far! This should make list updates much more efficient. Thanks for putting this together 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
This is just a try/proposal for #35 to use array item level events to avoid all items being updated each time
any comments, suggestions, ideas, commits are welcome.
currently this is not even yet tested on any projects, just tests are passing