Skip to content
This repository was archived by the owner on Sep 4, 2020. It is now read-only.

#35 WIP: try to use child_added event to avoid updating whole array for single item being added#37

Open
ciekawy wants to merge 1 commit into
adriancarriger:masterfrom
ciekawy:use_child_events_for_list_updates
Open

#35 WIP: try to use child_added event to avoid updating whole array for single item being added#37
ciekawy wants to merge 1 commit into
adriancarriger:masterfrom
ciekawy:use_child_events_for_list_updates

Conversation

@ciekawy

@ciekawy ciekawy commented May 17, 2017

Copy link
Copy Markdown
Contributor

DO NOT MERGE
This is just a try/proposal for #35 to use array item level events to avoid all items being updated each time

any comments, suggestions, ideas, commits are welcome.

currently this is not even yet tested on any projects, just tests are passing

@codecov-io

codecov-io commented May 17, 2017

Copy link
Copy Markdown

Codecov Report

Merging #37 into master will decrease coverage by 3.88%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
- Coverage    97.8%   93.92%   -3.89%     
==========================================
  Files           6        6              
  Lines         319      329      +10     
  Branches       45       46       +1     
==========================================
- Hits          312      309       -3     
- Misses          7       20      +13
Impacted Files Coverage Δ
src/database/database.ts 85.5% <33.33%> (-9.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e772ad9...8087d21. Read the comment docs.

@adriancarriger

Copy link
Copy Markdown
Owner

I really like what I see so far! This should make list updates much more efficient. Thanks for putting this together 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants