Skip to content

chore: Revert "feat: Keyboard shortcut handler"#10197

Merged
LFDanLu merged 1 commit into
mainfrom
revert-9929-keyboard-shortcut-handler
Jun 12, 2026
Merged

chore: Revert "feat: Keyboard shortcut handler"#10197
LFDanLu merged 1 commit into
mainfrom
revert-9929-keyboard-shortcut-handler

Conversation

@LFDanLu

@LFDanLu LFDanLu commented Jun 12, 2026

Copy link
Copy Markdown
Member

Reverts #9929

@snowystinger we found some bugs caused by some of the changes here (see #10195) and some open questions w/ regards to a certain class of issue (if you have multiple useKeyboard calls being wrapped and each has a different opinion on if propagation should stop or continue, which should win), and it seems like you've ran into other issues with #10187 and #10192) so lets chat about if we want to revert/try to get this into the release

@LFDanLu LFDanLu changed the title Revert "feat: Keyboard shortcut handler" chore: Revert "feat: Keyboard shortcut handler" Jun 12, 2026
@LFDanLu LFDanLu enabled auto-merge June 12, 2026 22:23
@rspbot

rspbot commented Jun 12, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Jun 12, 2026

Copy link
Copy Markdown
## API Changes

@react-aria/interactions

/@react-aria/interactions:KeyboardProps

 KeyboardProps {
-  allowComposing?: boolean
-  allowRepeats?: boolean
   isDisabled?: boolean
   onKeyDown?: (KeyboardEvent) => void
   onKeyUp?: (KeyboardEvent) => void
-  shortcuts?: KeyboardShortcutBindings
 }

@LFDanLu LFDanLu added this pull request to the merge queue Jun 12, 2026
Merged via the queue into main with commit 04a9b04 Jun 12, 2026
30 of 32 checks passed
@LFDanLu LFDanLu deleted the revert-9929-keyboard-shortcut-handler branch June 12, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants