chore: Revert "feat: Keyboard shortcut handler"#10197
Merged
Merged
Conversation
This reverts commit 9e1b070.
reidbarber
approved these changes
Jun 12, 2026
devongovett
approved these changes
Jun 12, 2026
|
Build successful! 🎉 |
## API Changes
@react-aria/interactions/@react-aria/interactions:KeyboardProps KeyboardProps {
- allowComposing?: boolean
- allowRepeats?: boolean
isDisabled?: boolean
onKeyDown?: (KeyboardEvent) => void
onKeyUp?: (KeyboardEvent) => void
- shortcuts?: KeyboardShortcutBindings
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #9929
@snowystinger we found some bugs caused by some of the changes here (see #10195) and some open questions w/ regards to a certain class of issue (if you have multiple useKeyboard calls being wrapped and each has a different opinion on if propagation should stop or continue, which should win), and it seems like you've ran into other issues with #10187 and #10192) so lets chat about if we want to revert/try to get this into the release